[Openmp-commits] [PATCH] D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme.

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added a comment.

I only have one other suggestion. I think its fine to use `uppercase_CMAKE_BUILD_TYPE` since its defined everywhere. The `DEBUG_BUILD` (and friends) are useful as booleans for `append_if()` type macro/functions in CMake.



================
Comment at: openmp/CMakeLists.txt:97
 
+option(MSVC_NAME_SCHEME "Build dll with MSVC naming scheme." OFF)
 
----------------
All the user-definable CMake variables in this CMakeLists.txt should be prefixed with `OPENMP_`, so I think the variable should be `OPENMP_MSVC_NAME_SCHEME`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110354/new/

https://reviews.llvm.org/D110354