[Openmp-commits] [PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one nit.



================
Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231
+      VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr, Size}));
+}
----------------
Suggestion: I feel this could be in a helper to avoid the duplication with the nvptx version. All but the extra argument is the same, no?


================
Comment at: openmp/libomptarget/DeviceRTL/src/Debug.cpp:61
+}
 }
 
----------------
Namespace above should include _OMP, be anonymous or the functions should be static.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112680/new/

https://reviews.llvm.org/D112680