[Openmp-commits] [PATCH] D113124: [OpenMP] Avoid costly shadow map traversals whenever possible

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 3 10:02:39 PDT 2021


jdoerfert created this revision.
jdoerfert added reviewers: jhuber6, ggeorgakoudis, tianshilei1992, ye-luo, grokos.
Herald added subscribers: guansong, bollu, yaxunl.
jdoerfert requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

In the OpenMC app we saw `omp target update` spending an awful lot of
time in the shadow map traversal without ever doing any update there.
There are two cases that allow us to avoid the traversal completely.
The simplest thing is that small updates cannot (reasonably) contain
an attached pointer part. The other case requires to track in the
mapping table if an entry might contain an attached pointer as part.
Given that we have a single location shadow map entries are created,
the latter is actually fairly easy as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113124

Files:
  openmp/libomptarget/include/device.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/omptarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113124.384501.patch
Type: text/x-patch
Size: 14053 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211103/0db5ae27/attachment.bin>


More information about the Openmp-commits mailing list