[Openmp-commits] [PATCH] D111788: [OpenMP] Add OMPT support for omp_all_memory task dependence

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:626-627
       ompt_deps[i].variable.ptr = (void *)dep_list[i].base_addr;
-      if (dep_list[i].flags.in && dep_list[i].flags.out)
+      if (dep_list[i].base_addr == KMP_SIZE_T_MAX)
+        ompt_deps[i].dependence_type = ompt_dependence_type_out_all_memory;
+      else if (dep_list[i].flags.in && dep_list[i].flags.out)
----------------
dreachem wrote:
> When would this condition occur in an OpenMP program? Why isn't it enough to just look at whether `flags.all` is set, as is done below?
D108574 lists two possible compiler interfaces for omp_all_memory. One of them is `dependence_address == SIZE_MAX`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111788/new/

https://reviews.llvm.org/D111788