[Openmp-commits] [PATCH] D103058: [libomptarget][nfc] Move hostcall required test to rtl

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 25 01:52:08 PDT 2021


JonChesterfield added a comment.

Side point on races - I think it is possible for one thread to start loading a binary, get immediately suspended, and a second thread to then launch a kernel that is supposed to come from that binary. The locking scheme in this plugin probably doesn't handle that. Hopefully libomptarget does have locking that makes that work, otherwise the cuda plugin is probably also racy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103058/new/

https://reviews.llvm.org/D103058



More information about the Openmp-commits mailing list