[Openmp-commits] [PATCH] D103058: [libomptarget][nfc] Move hostcall required test to rtl

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

Hostcall exists as a libraries in rocm, aomp and my github. Trunk has hooks - mostly weak symbols - to allow the host plugin source to work with or without it present.

The variable that is checked for (before and after this change) is introduced by a common variable in the GPU entry point for hostcalls. The idea is to only spin up the thread(s) associated with hostcall if the GPU will use it.

  __asm__("; hostcall_invoke: record need for hostcall support\n\t"
          ".type needs_hostcall_buffer, at object\n\t"
          ".global needs_hostcall_buffer\n\t"
          ".comm needs_hostcall_buffer,4":::);

This removes one of the remaining uses of the symbol info table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103058/new/

https://reviews.llvm.org/D103058