[Openmp-commits] [PATCH] D102346: [libomptarget][amdgpu] Remove majority of fatal errors

Pushpinder Singh via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu May 20 04:26:43 PDT 2021


pdhaliwal added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:1061
       // the comgr method of getting symbol info
-      if (HSA_STATUS_ERROR_INVALID_CODE_OBJECT != HSA_STATUS_SUCCESS) {
-        printf("[%s:%d] %s failed: %s\n", __FILE__, __LINE__,
-               "Invalid kernel name",
-               get_error_string(HSA_STATUS_ERROR_INVALID_CODE_OBJECT));
-        exit(1);
-      }
+      return HSA_STATUS_ERROR;
     }
----------------
`char *name` is leaking on these exits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102346/new/

https://reviews.llvm.org/D102346



More information about the Openmp-commits mailing list