[Openmp-commits] [PATCH] D102346: [libomptarget][amdgpu] Remove majority of fatal errors

[Pushpinder Singh via Phabricator via Openmp-commits]

pdhaliwal accepted this revision.
pdhaliwal added a comment.
This revision is now accepted and ready to land.

Looks good with one minor NIT.



================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:142
+      } else {
+        core::allow_access_to_all_gpu_agents(kernarg_region);
+        for (int i = 0; i < MAX_NUM_KERNELS; i++) {
----------------
should check for return status here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102346/new/

https://reviews.llvm.org/D102346