[Openmp-commits] [PATCH] D102043: [libomptarget] Look for plugins next to libomptarget.so

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu May 6 19:45:48 PDT 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/src/rtl.cpp:68
 
+namespace {
+std::string findLibomptargetDirectory() {
----------------
Would rather use llvm filesystem here but that patch hasn't landed yet. Should we use std::filesystem?

I don't think dlopen works on windows anyway so one more unix convention in this file seems acceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102043/new/

https://reviews.llvm.org/D102043



More information about the Openmp-commits mailing list