[Openmp-commits] [PATCH] D102043: [libomptarget] Look for plugins next to libomptarget.so

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

See D73657 <https://reviews.llvm.org/D73657> D87413 <https://reviews.llvm.org/D87413> for similar approaches to the same problem. dladdr appears to be available on more systems than dlinfo and link.h, and means we don't need to know what libomptarget.so was called (e.g. if it has trailing .1 versioning).

The failure mode here is dladdr() returns zero, findLibomptargetDirectory returns "" and verbose_dlopen will be called twice on the same Name. That looks cleaner than the extra test for if dladdr succeeded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102043/new/

https://reviews.llvm.org/D102043