[Openmp-commits] [PATCH] D98838: [OpenMP] Fixed a crash in hidden helper thread

Thu Mar 18 12:30:34 PDT 2021

protze.joachim added a comment.

`LIBOMP_NUM_HIDDEN_HELPER_THREADS=0` avoids the segfault/assertion for the two test cases I attached to the bugzilla issue. This kind of makes sense, as 0 hidden threads cannot create a hole in the __kmp_threads array.

If you still see performance regression (I could not reproduce this with lbm built from SPEC CPU 2006, for which I explicitly turned on the contained OpenMP code), I guess the code adds some additional synchronization, which was not there before.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98838/new/

https://reviews.llvm.org/D98838