[Openmp-commits] [PATCH] D98838: [OpenMP] Fixed a crash in hidden helper thread

Thu Mar 18 12:04:52 PDT 2021

jdoerfert added a comment.

In D98838#2634873 <https://reviews.llvm.org/D98838#2634873>, @ronlieb wrote:

> In Wednesdays multi company meeting, we concluded that the helper task patch should be reverted from llvm 12 while we continued to actively work issues in trunk.
>
> Who is taking care of that ? or whom should we notify ?

I also don't recall that conclusion.

In D98838#2634957 <https://reviews.llvm.org/D98838#2634957>, @JonChesterfield wrote:

> We should pull this from the 12 release. Lots of effort at the last minute to stop a complicated patch asserting, after it has been patched several times already, is unlikely to yield a stable release.

Pulling this is not necessarily easy either, I haven't checked though.
Have you or @ronlieb tried this solution, especially if the environment
variable now works to disable all the side-effects?

---

Let me be direct for a second so we don't end up here again in a few months:
The patch was on phab for ~1 year, nobody cared, this is a very common phenomena.
It also has been merged for weeks. I get the fact that we want a stable release
but showing up last minute just saying we need to pull stuff is *not* helpful
from an overall perspective. I say this especially because the number of people/
organizations that develop and upstream complex features is very limited. If you
want to benefit from such efforts you should be prepared to help, IMHO. That does
mean to do some testing and reviewing *before* the last release candidate is due.
Not to say this was not tested, but the capabilities are arguably different here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98838/new/

https://reviews.llvm.org/D98838