[Openmp-commits] [PATCH] D96893: [OpenMP] libomp minor cleanup

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

I'm only partially familiar with the depnode code, since I investigated similar issues before. I added the `__kmp_node_ref` in line 777, so that `__kmp_node_deref` would not try to free the stack-allocated node, when the refcount turns 0. 
It was not obvious to me, that other nodes could still have references, when the while loop ends. Looking at `__kmp_release_deps` it looks like npredecessors might get 0 before the reference to the node is cleared. The easiest fix would be to heap-allocate the depnode. @AndreyChurbanov , what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96893/new/

https://reviews.llvm.org/D96893