[Openmp-commits] [PATCH] D96893: [OpenMP] libomp minor cleanup

[Di Mo via Phabricator via Openmp-commits]

modimo added a comment.

That makes sense, thanks for the explanation and additional investigation @protze.joachim!

Given we're observing a assert failure because of the dangling reference in `__kmp_node_deref` it suggests the runtime needs access to coherent state on these references. Given that memory freeing may be called on random stack values there's crash or double free potential based on my quick scan of `__kmp_fast_free`. Given this I think there's a need to fix the root cause. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96893/new/

https://reviews.llvm.org/D96893