[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL

Ron Lieberman via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 16 08:31:34 PDT 2021


ronlieb added a comment.

latest trunk has the assert in question at line 3651
 3638    } else {

  3639      /* find an available thread slot */
  3640      // Don't reassign the zero slot since we need that to only be used by
  3641      // initial thread. Slots for hidden helper threads should also be skipped.
  3642      if (initial_thread && __kmp_threads[0] == NULL) {
  3643        gtid = 0;
  3644      } else {
  3645        for (gtid = __kmp_hidden_helper_threads_num + 1;
  3646             TCR_PTR(__kmp_threads[gtid]) != NULL; gtid++)
  3647          ;
  3648      }
  3649      KA_TRACE(
  3650          1, ("__kmp_register_root: found slot in threads array: T#%d\n", gtid));
  3651      KMP_ASSERT(gtid < __kmp_threads_capacity);
  3652    }

our jan 27th internal merge has this at line 3691 of kmp_runtime.cpp

3678    } else {

  3679      /* find an available thread slot */
  3680      // Don't reassign the zero slot since we need that to only be used b

y

  3681      // initial thread. Slots for hidden helper threads should also be sk

ipped.

  3682      if (initial_thread && __kmp_threads[0] == NULL) {
  3683        gtid = 0;
  3684      } else {
  3685        for (gtid = __kmp_hidden_helper_threads_num + 1;
  3686             TCR_PTR(__kmp_threads[gtid]) != NULL; gtid++)
  3687          ;
  3688      }
  3689      KA_TRACE(
  3690          1, ("__kmp_register_root: found slot in threads array: T#%d\n",

gtid));

  3691      KMP_ASSERT(gtid < __kmp_threads_capacity);
  3692    }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609



More information about the Openmp-commits mailing list