[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL

[Joachim Protze via Openmp-commits]

Hi Ron,

even without a reproducer, it would certainly help, if you can map your
line 3691 to a line of code we can find in the upstream repository.
Neither main nor the release branch have an assertion on that line:

https://github.com/llvm/llvm-project/blob/main/openmp/runtime/src/kmp_runtime.cpp#L3691

https://github.com/llvm/llvm-project/blob/release/12.x/openmp/runtime/src/kmp_runtime.cpp#L3691

Best
Joachim


Am 15.03.21 um 20:53 schrieb Lieberman, Ron:
> [AMD Official Use Only - Internal Distribution Only]
> 
> I was requested to add the information about the failure observed in our product testing, so I added comment to your patch so you would be aware of it. Perhaps down the road someone will encounter it with a simpler upstream testcase.
> 
> I don't have a small reproducer,  however the release engineer  (David cc'ed) says it might take him a few hours or more. He is willing to try, so maybe you will be able to provide one....  might be today or tomorrow.
> 
> Ron
> 
> -----Original Message-----
> From: Shilei Tian via Phabricator <reviews at reviews.llvm.org> 
> Sent: Monday, March 15, 2021 3:37 PM
> To: tianshilei1992 at gmail.com; jdoerfert at anl.gov; andrey.churbanov at intel.com; alejandro.duran at intel.com
> Cc: jonathanchesterfield at gmail.com; Lieberman, Ron <Ron.Lieberman at amd.com>; martin at martin.st; rofirrim at gmail.com; xw111luoye at gmail.com; daniel.kiss at arm.com; aaron.ballman at gmail.com; protze.joachim at gmail.com; stefomeister at gmail.com; Islam, Saiyedul <Saiyedul.Islam at amd.com>; reviews.llvm.org at jfbastien.com; mgorny at gentoo.org; Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; zhang.guansong at gmail.com; openmp-commits at lists.llvm.org; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; lin32 at llnl.gov; Singh, Pushpinder <Pushpinder.Singh at amd.com>; liao6 at llnl.gov; sara.royuela at bsc.es; Tomar, Sourabh Singh <SourabhSingh.Tomar at amd.com>; deepak.eachempati at hpe.com; jatin.bhateja at gmail.com; greg63706 at gmail.com; ravi.narayanaswamy at intel.com
> Subject: [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL
> 
> [CAUTION: External Email]
> 
> tianshilei1992 added a comment.
> 
> Without a reproducer, I cannot tell what was going wrong. And your code is out of date. What is the assertion at line 3691 in `kmp_runtime.cpp`?
> 
> 
> Repository:
>   rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>   https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD77609%2Fnew%2F&data=04%7C01%7Cron.lieberman%40amd.com%7C6ee0f6c4cd314f46680c08d8e7e9bc51%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637514338405968941%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Wsozg9gfePL5QCXWIZkkPaVpD%2B%2BHDMtsngdgVIWNgVg%3D&reserved=0
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD77609&data=04%7C01%7Cron.lieberman%40amd.com%7C6ee0f6c4cd314f46680c08d8e7e9bc51%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637514338405968941%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ICMZMauXdSwPBoxyCEOUhcjr8fYfhY4P6F%2BgpwIWkaY%3D&reserved=0
>