[Openmp-commits] [PATCH] D104710: [OpenMP] Introduce an CMake find module for OpenMP Target support

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/tools/Modules/FindOpenMPTarget.cmake:1
+##===----------------------------------------------------------------------===##
+#
----------------
tianshilei1992 wrote:
> Is it better to put these files into `libomptarget`?
We don't have a `tools` directory under that, I figured it's fine in the same way we put the `libomptarget` documentation under `openmp/docs`.


================
Comment at: openmp/tools/Modules/FindOpenMPTarget.cmake:87
+cmake_policy(PUSH)
+cmake_policy(VERSION 3.17)
+
----------------
tianshilei1992 wrote:
> Not sure if it is too strict. LLVM and OpenMP both require CMake 3.13.4 and above.
I think the only things preventing me from using 3.13.4 is that the OpenMP module doesn't seem to return the version correctly, and it doesn't support the "NAME_MISMATCHED" which means that newer CMake will emit a warning for finding a package with a different name than the one specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104710/new/

https://reviews.llvm.org/D104710