[Openmp-commits] [PATCH] D104710: [OpenMP] Introduce an CMake find module for OpenMP Target support

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM. Some nits.



================
Comment at: openmp/tools/Modules/FindOpenMPTarget.cmake:1
+##===----------------------------------------------------------------------===##
+#
----------------
Is it better to put these files into `libomptarget`?


================
Comment at: openmp/tools/Modules/FindOpenMPTarget.cmake:87
+cmake_policy(PUSH)
+cmake_policy(VERSION 3.17)
+
----------------
Not sure if it is too strict. LLVM and OpenMP both require CMake 3.13.4 and above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104710/new/

https://reviews.llvm.org/D104710