[Openmp-commits] [PATCH] D103813: [AMDGPU][Libomptarget] Drop dead code related to g_atl_machine

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

LG. My preference would be as commented above, but the vector containing the contents of the other two works too.



================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:573
     }
-
-    std::tie(err, KernArgPool) = core::FindKernargPool(HSAAgents);
+    std::tie(err, KernArgPool) = core::FindKernargPool(AllAgents);
     if (err != HSA_STATUS_SUCCESS) {
----------------
pdhaliwal wrote:
> JonChesterfield wrote:
> > I'm not sure this needs AllAgents - shouldn't one of the subsets (iirc it would be HSAAgents) suffice?
> Normally kernarg is found in CPUAgents, so I included both in case HSAAgents also have kernarg pool.
I think we should go with passing the list we currently see the kernarg segment in, partly to alert us if a future system changes that association, and partly because it's fractionally faster code that way. I think that also drops the AllAgents vector so there's less redundant state lying around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103813/new/

https://reviews.llvm.org/D103813