[Openmp-commits] [PATCH] D103813: [AMDGPU][Libomptarget] Drop dead code related to g_atl_machine

[Pushpinder Singh via Phabricator via Openmp-commits]

pdhaliwal marked an inline comment as done.
pdhaliwal added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:573
     }
-
-    std::tie(err, KernArgPool) = core::FindKernargPool(HSAAgents);
+    std::tie(err, KernArgPool) = core::FindKernargPool(AllAgents);
     if (err != HSA_STATUS_SUCCESS) {
----------------
JonChesterfield wrote:
> I'm not sure this needs AllAgents - shouldn't one of the subsets (iirc it would be HSAAgents) suffice?
Normally kernarg is found in CPUAgents, so I included both in case HSAAgents also have kernarg pool.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103813/new/

https://reviews.llvm.org/D103813