[Openmp-commits] [PATCH] D106674: Runtime for Interop directive

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 27 08:51:26 PDT 2021


jdoerfert added a comment.

@AndreyChurbanov @tianshilei1992  Any concerns with merging this today if the two things below are addressed?



================
Comment at: openmp/runtime/src/dllexports:553
+    omp_get_interop_ptr                     761
+    omp_get_interop_str                     762
 
----------------
Those values are taken by now, you need new values that are not taken yet.


================
Comment at: openmp/runtime/src/kmp_ftn_entry.h:1546
+  return nullptr;
+}
+
----------------
We need the `KMP_DLSYM_NEXT` lookup in these, probably sufficient to do only that lookup though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106674/new/

https://reviews.llvm.org/D106674



More information about the Openmp-commits mailing list