[Openmp-commits] [PATCH] D106674: Runtime for Interop directive

[Sri Hari Krishna Narayanan via Phabricator via Openmp-commits]

sriharikrishna added inline comments.


================
Comment at: openmp/libomptarget/src/interop.cpp:177
+void __kmpc_interop_init(ident_t *loc_ref, kmp_int32 gtid,
+                         omp_interop_val_t *&interop_ptr,
+                         kmp_interop_type_t interop_type, kmp_int32 device_id,
----------------
sriharikrishna wrote:
> jdoerfert wrote:
> > don't use references in this code with C bindings. Use a ** instead and change left-hand-side uses to `*interop_ptr`. This will then also match D105876 where all 3 functions are declared to take a `void**`. That means `_use` below should take a `void**` as well.
> It is not clear how to fix this. In the user code's interop directive, the interop variable must be of type 'omp_interop_t'. So getting 
Incorrect comment above. This is fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106674/new/

https://reviews.llvm.org/D106674