[Openmp-commits] [PATCH] D95669: Make OpenMP's lit.cfg python 3 compatible

Tobias Hieta via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jan 29 03:36:42 PST 2021


thieta added inline comments.


================
Comment at: openmp/runtime/test/lit.cfg:79
   out, err = cmd.communicate()
-  out = out.strip()
+  out = out.strip().decode()
   res = cmd.wait()
----------------
protze.joachim wrote:
> Isn't `strip()` also a string method? I'd expect that you want to decode first, then strip.
strip() works on byte objects as well as far as I can understand the python docs. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95669/new/

https://reviews.llvm.org/D95669



More information about the Openmp-commits mailing list