[Openmp-commits] [PATCH] D95669: Make OpenMP's lit.cfg python 3 compatible

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jan 29 03:23:19 PST 2021


protze.joachim added a comment.

Next time please provide the full context of the change as suggested in the guide: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface



================
Comment at: openmp/runtime/test/lit.cfg:79
   out, err = cmd.communicate()
-  out = out.strip()
+  out = out.strip().decode()
   res = cmd.wait()
----------------
Isn't `strip()` also a string method? I'd expect that you want to decode first, then strip.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95669/new/

https://reviews.llvm.org/D95669



More information about the Openmp-commits mailing list