[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added inline comments.


================
Comment at: openmp/libomptarget/src/CMakeLists.txt:35
+    )
+  add_llvm_library(omptarget SHARED ${src_files}
+      LINK_LIBS ${CMAKE_DL_LIBS}
----------------
jdoerfert wrote:
> vzakhari wrote:
> > Hello.  This function adds a `LLVM_VERSION_MAJOR` suffix to `libomptarget` library name, and `libomptarget.so` is just a link now.  This actually causes dynamic dependency in the executables to be set to `libomptarget.so.##git`.  When LLVM changes its major version, I guess all the executables built with the previous version will stop working.  Is this expected or I am missing something?
> The way I understand you this seems desirable.
I am not sure why we want to make `libomptarget` versioning dependent on `llvm` versioning.  We used to have backward compatible `libomptarget`, i.e. an executable built with `llvm12` `libomptarget` could work with `llvm13` `libomptarget` even if there was a breaking `LLVM IR` change between these two versions of `llvm`.  Now we disallow this, but it does not seem like this was the main goal of this commit.

I bthink if we want to introduce versioning for `libomptarget` it should be independent of `llvm` versioning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055