[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/CMakeLists.txt:35
+    )
+  add_llvm_library(omptarget SHARED ${src_files}
+      LINK_LIBS ${CMAKE_DL_LIBS}
----------------
vzakhari wrote:
> Hello.  This function adds a `LLVM_VERSION_MAJOR` suffix to `libomptarget` library name, and `libomptarget.so` is just a link now.  This actually causes dynamic dependency in the executables to be set to `libomptarget.so.##git`.  When LLVM changes its major version, I guess all the executables built with the previous version will stop working.  Is this expected or I am missing something?
The way I understand you this seems desirable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055