[Openmp-commits] [PATCH] D95530: [libomptarget] Load images in order of registration

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/src/rtl.h:57
   typedef int32_t (*register_lib_ty)(__tgt_bin_desc *);
+  typedef int32_t(supports_empty_images_ty)();
 
----------------
JonChesterfield wrote:
> This is weird. Most of these typedefs are for function types, as opposed to the corresponding function pointer type. I guess matching the existing ones is right, but I think we're missing a '*' in most of these.
It starts from `register_lib_ty` and `unregister_lib`. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95530/new/

https://reviews.llvm.org/D95530