[Openmp-commits] [PATCH] D95530: [libomptarget] Load images in order of registration

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

There are two changes here. Loading images in a given order and loading images even if they look empty.

I'd personally split this, because annoying though it is to split a change, the whole thing is likely to be reverted if part of it turns out to be faulty.

Should fix the formatting nit above before landing. git-clang-format is great for that.



================
Comment at: openmp/libomptarget/src/rtl.h:57
   typedef int32_t (*register_lib_ty)(__tgt_bin_desc *);
+  typedef int32_t(supports_empty_images_ty)();
 
----------------
This is weird. Most of these typedefs are for function types, as opposed to the corresponding function pointer type. I guess matching the existing ones is right, but I think we're missing a '*' in most of these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95530/new/

https://reviews.llvm.org/D95530