[Openmp-commits] [PATCH] D102043: [libomptarget] Look for plugins next to libomptarget.so

[Greg Rodgers via Phabricator via Openmp-commits]

gregrodgers requested changes to this revision.
gregrodgers added inline comments.
This revision now requires changes to proceed.


================
Comment at: openmp/libomptarget/src/rtl.cpp:107
+                              ? nullptr
+                              : dlopen(AdjacentPluginName.c_str(), RTLD_NOW);
 
----------------
jdoerfert wrote:
> This doesn't make sense now as it will fail to load plugins if we failed to determine the path, it also fails to prefer plugins on the user path. Or am I reading this wrong?
I agree here.  instead of "nullptr", it should be "dlopen(Name, RTLD_NOW)"  This will use the LIBRARY_PATH search if findLibomptargetDirectory could not find the library.  

I agree with the minor change in behavior to get the plugins from the same directory as libomptarget.so first and if not found (libomptarget is statically linked), then do the LIBRARY_PATH search. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102043/new/

https://reviews.llvm.org/D102043