[Openmp-commits] [PATCH] D102043: [libomptarget] Look for plugins next to libomptarget.so

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D102043#2967759 <https://reviews.llvm.org/D102043#2967759>, @jdoerfert wrote:

> I c. This needs discussion Wednesday though. I am not sure there is a problem changing the default behavior but I want to hear out others.

OK, Wednesday it is. The use case is essentially machines that have N llvm toolchains installed, some in system directories, some accessed by cluster module systems. As it stands it is really easy to have libomptarget.so pick up a totally unrelated plugin, and because it's via dlopen and the print just gives the library name, working out that this is the problem would take a while to debug. Probably at the point where people are running strace on their application.

Changing to this patch retains the current control over libomptarget.so but eliminates that failure mode.

In D102043#2967759 <https://reviews.llvm.org/D102043#2967759>, @jdoerfert wrote:

> If this should not fail, please make it a proper error output. There is no point in it silently not finding plugins and people being all confused about it.

Fair enough, will do so. I'll find an analogous case in libomptarget and copy that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102043/new/

https://reviews.llvm.org/D102043