[Openmp-commits] [PATCH] D107656: [OpenMP] Use events and taskyield in target nowait task to unblock host threads

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:407-408
   TIMESCOPE_WITH_IDENT(loc);
   if (depNum + noAliasDepNum > 0)
     __kmpc_omp_taskwait(loc, __kmpc_global_thread_num(loc));
 
----------------
RaviNarayanaswamy wrote:
> Is kmpc_omp_taskwait needed.
It is not needed. It has been removed by @tianshilei1992 in main branch. So It will disappear after a rebase.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:73
   }
   return Result;
 }
----------------
RaviNarayanaswamy wrote:
> Result is not set on all paths
When leaving line 62, the return value is OFFLOAD_SUCCESS as line 28 sets it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107656/new/

https://reviews.llvm.org/D107656