[Openmp-commits] [PATCH] D107656: [OpenMP] Use events and taskyield in target nowait task to unblock host threads

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:407-408
   TIMESCOPE_WITH_IDENT(loc);
   if (depNum + noAliasDepNum > 0)
     __kmpc_omp_taskwait(loc, __kmpc_global_thread_num(loc));
 
----------------
Is kmpc_omp_taskwait needed.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:73
   }
   return Result;
 }
----------------
Result is not set on all paths


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107656/new/

https://reviews.llvm.org/D107656