[Openmp-commits] [PATCH] D101266: [OpenMP][CMake] Pass --cuda-path to regression tests.

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D101266#2718171 <https://reviews.llvm.org/D101266#2718171>, @Meinersbur wrote:

> In D101266#2717667 <https://reviews.llvm.org/D101266#2717667>, @JonChesterfield wrote:
>
>> The ld_library_path requirement is nasty. We should burn rpath/runpath into the cuda plugin (and probably also corresponding rpath/runpath into executables so they can find the openmp runtime libraries)
>
> What is so nasty about it? It is already sets a couple of other library paths. rpath unfortunately is less portable.

It leaks an internal detail to the user. Someone builds their application with openmp enabled, goes to run it, and it fails because it can't find the libraries that clang implicitly created dependencies on, even though clang knows where said dependencies are. Defaulting to the openmp that ships with clang removes that hurdle and still lets people override it with LD_LIBRARY_PATH if they wish (iirc it's RUNPATH that allows that override and rpath that doesn't).

As far as I know rpath works everywhere, but where it doesn't, those users can continue doing whatever they do today to find the libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101266/new/

https://reviews.llvm.org/D101266