[Openmp-commits] [PATCH] D101266: [OpenMP][CMake] Pass --cuda-path to regression tests.

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur marked an inline comment as done.
Meinersbur added a comment.

In D101266#2717667 <https://reviews.llvm.org/D101266#2717667>, @JonChesterfield wrote:

> The ld_library_path requirement is nasty. We should burn rpath/runpath into the cuda plugin (and probably also corresponding rpath/runpath into executables so they can find the openmp runtime libraries)

What is so nasty about it? It is already sets a couple of other library paths. rpath unfortunately is less portable.

Does someone know why in one place it is `prepend_library_path`, but `append_dynamic_library_path` in the other? I think all libraries should be pre-pended, in order to take precedence over other system-installed libraries, such as in paths set by `module load cuda`/`module load llvm`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101266/new/

https://reviews.llvm.org/D101266