[Openmp-commits] [PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

Fri Apr 2 22:24:37 PDT 2021

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, thanks

================
Comment at: openmp/runtime/src/include/omp.h.var:479
+#   endif
+
 #   undef __KAI_KMPC_CONVENTION
----------------
hbae wrote:
> jdoerfert wrote:
> > Do we want them to be static? I would have expected odr linkage instead.
> > 
> > 
> > 
> Current clang fails to link two files that include omp.h, so I think we need static here.
I would expect this to cause "unused function" warnings if you include omp.h.
That said, given that clang might be the only impl. so far for begin/end declare variant and it doesn't warn, we can go ahead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99447/new/

https://reviews.llvm.org/D99447