[Openmp-commits] [PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

Hansang Bae via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Apr 2 15:13:52 PDT 2021


hbae added inline comments.


================
Comment at: openmp/runtime/src/include/omp.h.var:479
+#   endif
+
 #   undef __KAI_KMPC_CONVENTION
----------------
jdoerfert wrote:
> Do we want them to be static? I would have expected odr linkage instead.
> 
> 
> 
Current clang fails to link two files that include omp.h, so I think we need static here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99447/new/

https://reviews.llvm.org/D99447



More information about the Openmp-commits mailing list