[Openmp-commits] [PATCH] D87259: [OpenMPOpt][SplitMemTransfer] Implementation of the real issue and wait api functions.

[Hamilton Tobon Mosquera via Phabricator via Openmp-commits]

hamax97 added a comment.

In D87259#2301065 <https://reviews.llvm.org/D87259#2301065>, @grokos wrote:

> I think these API functions should also include the source location pointer from https://reviews.llvm.org/D87946. We need to consider renaming the `*_issue` and `*_wait` functions to extend the `*_loc` API the aforementioned patch is introducing. E.g. after D87946 <https://reviews.llvm.org/D87946> the "current" `data begin` API function will be `__tgt_target_data_begin_mapper_loc`, so this patch should extend that name as `__tgt_target_data_begin_mapper_loc_issue` and `__tgt_target_data_begin_mapper_loc_wait`. Because both patches make changes to the API, I think it's better to wait until the former patch has been committed.

Yes. It will be easier to add this patch after D87946 <https://reviews.llvm.org/D87946> and not the other way around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87259/new/

https://reviews.llvm.org/D87259