[Openmp-commits] [PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

Should we wait until the next OpenMP LLVM meeting to push this?



================
Comment at: openmp/libomptarget/include/Ident.h:48-51
+    auto removePath = [](const std::string &path) {
+        std::size_t pos = path.rfind('/');
+        return path.substr(pos + 1);
+    };
----------------
This will probably break with a Windows file path, but I don't think you can even build most offloading if you're on Windows. Should I just add a processor check?

```
#ifdef _WIN32
#define PATH_DELIMITER '\\'
#else
#define PATH_DELIMITER '/'
#endif
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946