[Openmp-commits] [PATCH] D88149: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one nit. Give @grokos and @RaviNarayanaswamy some time to comment or accept as well.



================
Comment at: openmp/runtime/src/kmp_ftn_entry.h:969
 #if KMP_MIC || KMP_OS_DARWIN || KMP_OS_WINDOWS || defined(KMP_STUB)
-  return KMP_HOST_DEVICE;
+  return 0; // omp_get_num_devices()
 #else
----------------
Nit: Please put the comments in the line before, also below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88149/new/

https://reviews.llvm.org/D88149