[Openmp-commits] [PATCH] D87841: [openmp][libomptarget] Include header from LLVM source tree

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 18 08:52:35 PDT 2020

tianshilei1992 added a comment.

In D87841#2281974 <https://reviews.llvm.org/D87841#2281974>, @jdoerfert wrote:

> In D87841#2281494 <https://reviews.llvm.org/D87841#2281494>, @grokos wrote:
>> 4. At CMake time, check whether llvm-core is there; if yes use `OMPGridValues.h` from llvm-core, if no then download the header from some suitable location automatically. This eliminates the need for (2) and makes both proponents of (1) and proponents of (3) happy.
> Most of our bigger machine have no internet. Download after the fact might also confuse people. I think telling the user to download and point to instead, as we do with other dependences, is in the grant scheme of things less surprising.

I think it might be better to provide both options: if users don't specify anything, using online download by default. If users specify the path to the headers, it then does not download.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list