[Openmp-commits] [PATCH] D87722: [OpenMP] Additional Information for Libomptarget Device Mappings

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:55
+DeviceTy::~DeviceTy() {
+    if (DeviceID != -1 && getInfoLevel() > 1) {
+      fprintf(stderr, "Device %d Destroyed. Final Host-Device Pointer "
----------------
early exit please.


================
Comment at: openmp/libomptarget/src/device.cpp:65
+      }
+    }
+}
----------------
please call dumpTargetPointerMappings, maybe pass the initial message as an argument or something but there is little gain in duplicating the logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87722/new/

https://reviews.llvm.org/D87722