[Openmp-commits] [PATCH] D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton updated this revision to Diff 291694.
jlpeyton added a comment.

Test was poorly constructed. Second attempt.

The test is three steps:

1. test a single independent task and make sure the `#pragma omp taskwait depend()` does not wait on that task. Also ensure that a worker thread grabs the task instead of the generating thread.

2. test a single task with irrelevant dependencies and make sure the `#pragma omp taskwait depend()` does not wait on that task. Also ensure that a worker thread grabs the task instead of the generating thread.

3. test a single dependent task which takes a while and make sure the `#pragma omp taskwait depend()` actually waits on it.

The test also forces at least two threads in the parallel region, and then rechecks to ensure that at least two threads were actually created for the parallel region.

The #pragma omp task if(0) depend() version of the test will be part of the GOMP fix if0 patch: D87271 <https://reviews.llvm.org/D87271>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87269/new/

https://reviews.llvm.org/D87269

Files:
  openmp/runtime/src/kmp_ftn_os.h
  openmp/runtime/src/kmp_gsupport.cpp
  openmp/runtime/test/tasking/omp50_taskwait_depend.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87269.291694.patch
Type: text/x-patch
Size: 5020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200914/91773770/attachment.bin>