[Openmp-commits] [PATCH] D77609: [OpenMP][WIP] Added the support for unshackled task in RTL

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Sep 9 07:07:44 PDT 2020


AndreyChurbanov added a comment.

Couple of tests needed to check if the implementation works - one with unshackled task encountered before parallel, and another with  unshackled task encountered after / between parallels.



================
Comment at: openmp/runtime/src/kmp_runtime.cpp:4323
+       TCR_PTR(__kmp_threads[new_gtid]) != NULL &&
+       new_gtid <= __kmp_unshackled_threads_num;
+       ++new_gtid) {
----------------
This condition is false if new_gtid started with (__kmp_unshackled_threads_num + 1), that is for regular thread.  Thus all threads will mistakenly get the same gtid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609



More information about the Openmp-commits mailing list