[Openmp-commits] [PATCH] D87165: [OpenMP] Begin Printing Information Dumps In Libomptarget and Plugins

Tue Sep 8 08:23:40 PDT 2020

jdoerfert added a comment.

In D87165#2261026 <https://reviews.llvm.org/D87165#2261026>, @jhuber6 wrote:

> Added the target kernel name and device ID to the message. Added a new method to get the offload entry given the pointer. I can't decide if it's better to just always print the device ID if we have it versus putting it in the macro itself.

I believe there is no reason to be somewhere in this methods without a device ID. Thus, I would require it as part of the function/macro.

> Does this require any test files?

I think that would be good. We should be able to set the INFO variable in the run line as well. Do we have a test for the DP macro we can copy?

================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:298
+    return nullptr;
+  }
+
----------------
can we replace findOffloadEntry with this please.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87165/new/

https://reviews.llvm.org/D87165