[Openmp-commits] [PATCH] D87165: [OpenMP] Begin Printing Information Dumps In Libomptarget and Plugins

[Ye Luo via Phabricator via Openmp-commits]

ye-luo requested changes to this revision.
ye-luo added inline comments.
This revision now requires changes to proceed.


================
Comment at: openmp/libomptarget/include/Debug.h:103
 
+#define INFO_MESSAGE(...)                                                      \
+  do {                                                                         \
----------------
Please document all the macros, in this file, like functions. Say a bit about their intended use case.


================
Comment at: openmp/libomptarget/src/interface.cpp:28
+////////////////////////////////////////////////////////////////////////////////
+/// manage the success or failure of a target construct
+static void dumpTargetPointerMappings() {
----------------
Update comments


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87165/new/

https://reviews.llvm.org/D87165