[Openmp-commits] [PATCH] D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE

Thu Sep 3 10:29:35 PDT 2020

Hahnfeld added a comment.

In D87084#2254700 <https://reviews.llvm.org/D87084#2254700>, @jdoerfert wrote:

> Other places need to be updated too: `data_sharing_init_stack_common` for one.
>
> Do we actually use this array? What happens if you make it a single element and update the function above?

IIRC this was only used in the old data sharing scheme for nested parallelism on the GPU, see also http://lists.llvm.org/pipermail/openmp-dev/2018-September/002160.html. This seems to be gone since D83349 <https://reviews.llvm.org/D83349>, AFAICT the arrays are only initialized (via the various code paths) but never used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87084/new/

https://reviews.llvm.org/D87084