[Openmp-commits] [PATCH] D86804: [OpenMP] Consolidate error handling and debug messages in Libomptarget

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one nit.



================
Comment at: openmp/libomptarget/plugins/common/elf_common.c:18
+#error Include elf_common.c in the plugin source AFTER DEBUG_PREFIX has\
+ been defined and macro DP(...) has been defined.
 #endif
----------------
grokos wrote:
> This message is not applicable anymore. The `DP(...)` macro used to be defined in each plugin, but now with this patch this is no longer the case. The macro in defined in `Debug.h`, so the right message here would be "... and Debug.h has been included".
remove "and macro DP(...) has been defined." as it always is (I think)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86804/new/

https://reviews.llvm.org/D86804