[Openmp-commits] [PATCH] D86804: [OpenMP] Consolidate error handling and debug messages in Libomptarget

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: openmp/libomptarget/include/Debug.h:12
+//
+// Each plugin RTL and libomp target define TARGET_NAME and DEBUG_PREFIX for use
+// when sending messages to the user. These indicate which RTL sent themessage
----------------
libomp target --> libomptarget


================
Comment at: openmp/libomptarget/include/Debug.h:13
+// Each plugin RTL and libomp target define TARGET_NAME and DEBUG_PREFIX for use
+// when sending messages to the user. These indicate which RTL sent themessage
+//
----------------
themessage --> the message


================
Comment at: openmp/libomptarget/plugins/common/elf_common.c:18
+#error Include elf_common.c in the plugin source AFTER DEBUG_PREFIX has\
+ been defined and macro DP(...) has been defined.
 #endif
----------------
This message is not applicable anymore. The `DP(...)` macro used to be defined in each plugin, but now with this patch this is no longer the case. The macro in defined in `Debug.h`, so the right message here would be "... and Debug.h has been included".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86804/new/

https://reviews.llvm.org/D86804