[Openmp-commits] [PATCH] D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/include/Ident.h:67
+  return name_str.substr(begin + 1, end - begin - 1);
+}
+
----------------
jdoerfert wrote:
> Nit: `getVariableNameFromNameT`? or similar, getName is too generic
Do you think I should change all references from `void **` to use some `name_t` in the runtime? I guess it makes it more obvious what it's supposed to be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90172/new/

https://reviews.llvm.org/D90172