[Openmp-commits] [PATCH] D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Oct 26 16:15:34 PDT 2020


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/include/Ident.h:67
+  return name_str.substr(begin + 1, end - begin - 1);
+}
+
----------------
Nit: `getVariableNameFromNameT`? or similar, getName is too generic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90172/new/

https://reviews.llvm.org/D90172



More information about the Openmp-commits mailing list